[PATCH] setup_kcore(): Fix incorrect function name in panic() call.

Geert Uytterhoeven Geert.Uytterhoeven at sonycom.com
Fri Nov 17 16:21:12 EST 2006


On Fri, 17 Nov 2006, Geert Uytterhoeven wrote:
> On Fri, 17 Nov 2006, Jeremy Kerr wrote:
> > 
> > > -			panic("mem_init: kmalloc failed\n");
> > > +			panic("setup_kcore: kmalloc failed\n");
> > 
> > How about:
> > 	
> > 	panic("%s: kmalloc_failed\n", __FUNCTION__);
> > 
> > To prevent this happening again?
> 
> You're right, thanks for the suggestion!

Updated patch below:
---

Subject: [PATCH] setup_kcore(): Fix incorrect function name in panic() call.

setup_kcore(): Fix incorrect function name in panic() call.

Signed-Off-By: Geert Uytterhoeven <Geert.Uytterhoeven at sonycom.com>

--- linux-ps3-geert.orig/arch/powerpc/mm/init_64.c	2006-11-15 10:05:17.000000000 +0900
+++ linux-ps3-geert/arch/powerpc/mm/init_64.c	2006-11-17 12:36:49.000000000 +0900
@@ -130,7 +130,7 @@ static int __init setup_kcore(void)
 		/* GFP_ATOMIC to avoid might_sleep warnings during boot */
 		kcore_mem = kmalloc(sizeof(struct kcore_list), GFP_ATOMIC);
 		if (!kcore_mem)
-			panic("mem_init: kmalloc failed\n");
+			panic("%s: kmalloc failed\n", __FUNCTION__);
 
 		kclist_add(kcore_mem, __va(base), size);
 	}


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven at sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium



More information about the Linuxppc-dev mailing list