[PATCH] Reorganise and then fixup the pseries cpu hotplug code

[Stephen Rothwell]

On Fri, 17 Nov 2006 15:44:00 +1100 Michael Ellerman <michael at ellerman.id.au> wrote:
>
> > initcall fucntions should return 0 or -<error>;  -ENODEV is ignored,
> > other nonzero values cause a log message if initcall debugging is enabled.
>
> OK. I wanted to return an error, so there's something in the log to show
> that cpu hotplug was disabled - but I didn't check what to return. I'll
> fix it up on Monday to return -ENOENT.

Which also won't do anything unless initcall debugging is enabled and,
even then, will just give an obscure message in the boot logs.  If you
want to log something, then you should explicitly call printk().

--
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20061117/b6cbb5fd/attachment.pgp>