[PATCH/RFC (take 3)] linkstation / kurobox support under arch/powerpc

[Guennadi Liakhovetski]

On Tue, 14 Nov 2006, Kumar Gala wrote:

> Out of interest how are you booting this kernel build & dts on the
> linkstation/kurobox? u-boot or wrapper?

u-boot.

> > diff --git a/arch/powerpc/boot/dts/kuroboxHG.dts b/arch/powerpc/boot/dts/kuroboxHG.dts
> > new file mode 100644
> > index 0000000..6c76ef6
> > --- /dev/null
> > +++ b/arch/powerpc/boot/dts/kuroboxHG.dts
> 
> would make more sense if this file was called linkstation.dts to match the
> Kconfig

Well, as I wrote in the patch description, there are several NAS devices 
which can be hopefully made to run one kernel with just different fdts. 
The systems are LinkStation-I (I think, there are 2 variants thereof: 
HDLAN and HGLAN), Kurobox (normal and HG version), Terastation (several 
variations). You can see them and other non-powerpc devices, e.g., here:
http://linkstationwiki.net/index.php?title=Main_Page
The kernel patch traditionally was called "linkstation", that's where the 
CONFIG name comes from too. However, the device I have is a KuroboxHG, 
therefore the dts file is called kuroboxHG.dts, as it is indeed system 
specific. Makes sense?

> > +		dma at 80001100 {
> > +			linux,phandle = <4100>;
> > +			#interrupt-cells = <1>;
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +			device_type = "dma";
> > +			compatible = "fsl-dma";
> > +			clock-frequency = <0>;
> > +			reg = <80001100 24>;
> > +			interrupts = <6 0>;
> > +			interrupt-parent = <4400>;
> > +		};
> > +
> > +		dma at 80001200 {
> > +			linux,phandle = <4200>;
> > +			#interrupt-cells = <1>;
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +			device_type = "dma";
> > +			compatible = "fsl-dma";
> > +			clock-frequency = <0>;
> > +			reg = <80001200 24>;
> > +			interrupts = <7 0>;
> > +			interrupt-parent = <4400>;
> > +		};
> 
> Can we drop the dma nodes?  are you using them for something.  I'd prefer not
> to specify what they look like until we figure out how to handle the various
> "features" between the families of FSL PPC's that share the DMA controller
> (10x, 824x, 83xx, 85xx)

Sure, will do.

> > +		i2c at 80003000 {
> > +			linux,phandle = <4300>;
> > +			device_type = "i2c";
> > +			compatible = "fsl-i2c";
> > +			clock-frequency = <0>;
> 
> Any reason for adding this clock-frequency property?

Copy-paste:-)

> > +		pic at 80040000 {
> > +			linux,phandle = <4400>;
> > +			#interrupt-cells = <2>;
> > +			#address-cells = <0>;
> > +			device_type = "open-pic";
> > +			compatible = "chrp,open-pic";
> > +			interrupt-controller;
> > +			reg = <80040000 40000>;
> > +			clock-frequency = <0>;		/* ??? */
> 
> Any reason for adding this clock-frequency property?

Ditto.

> > diff --git a/arch/powerpc/configs/kuroboxhg_defconfig b/arch/powerpc/configs/kuroboxhg_defconfig
> > new file mode 100644
> > index 0000000..136632f
> > --- /dev/null
> > +++ b/arch/powerpc/configs/kuroboxhg_defconfig
> 
> similar file rename comment linkstation_defconfig

Well, it should eventually be linkstation_defconfig, but so far it only 
has drivers for kuroboxhg, but, perhaps, you're right. As the goal is to 
have 1 kernel for all with one defconfig, I can rename it now and just 
hope it will be extended in the future as the patch is used / tested on 
more systems. Will rename, thanks.

So, I would leave most parts with "linkstation" notation, apart from the 
.dts, will throw unneeded entries from the .dts, rename the defconfig, but 
keep the .dts name. Agree?

Thanks
Guennadi
---
Guennadi Liakhovetski