[PATCH 1/1] libata: Convert from module_init to subsys_initcall (resend)

Brian King brking at us.ibm.com
Tue Nov 14 09:32:36 EST 2006


When building a monolithic kernel, the load order of drivers
does not work for SAS libata users, resulting in a kernel
oops. Convert libata to use subsys_initcall instead of
module_init, which ensures that libata gets loaded before
any LLDD. This is the same thing that scsi core does
to solve the problem. The load order problem was observed on
ipr SAS adapters and should exist for other SAS users as well.

Signed-off-by: Brian King <brking at us.ibm.com>
---

Jeff,

This is needed for 2.6.19 since without it monolithic kernels
on lots of PPC64 machines oops at boot time.
Please ack/nack as appropriate.

Thanks,

Brian
---

 linux-2.6-bjking1/drivers/ata/libata-core.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/ata/libata-core.c~libata_subsys_init drivers/ata/libata-core.c
--- linux-2.6/drivers/ata/libata-core.c~libata_subsys_init	2006-11-13 15:39:35.000000000 -0600
+++ linux-2.6-bjking1/drivers/ata/libata-core.c	2006-11-13 15:39:35.000000000 -0600
@@ -5957,7 +5957,7 @@ static void __exit ata_exit(void)
 	destroy_workqueue(ata_aux_wq);
 }
 
-module_init(ata_init);
+subsys_initcall(ata_init);
 module_exit(ata_exit);
 
 static unsigned long ratelimit_time;
_



More information about the Linuxppc-dev mailing list