[PATCH]: PowerPC: make sure the rtas stop-self token is defined.
Linas Vepstas
linas at austin.ibm.com
Tue Nov 14 05:05:00 EST 2006
On Mon, Nov 13, 2006 at 12:21:04AM -0600, jschopp wrote:
> >I can only find one caller? Is it called via a #define or something?
Right. I was looking at pSeries_mach_cpu_die(), which is called
as md.cpu_die from many places.
> >Wouldn't it be preferable to just change rtas.h like so:
> >
> >#ifdef CONFIG_HOTPLUG_CPU
> >extern void rtas_stop_self(void);
> >#else
> >static inline void rtas_stop_self(void) { }
> >#endif
Well, the problem is that this would just pass the BUG() to
the next level, in pSeries_mach_cpu_die():
static void pSeries_mach_cpu_die(void)
{
local_irq_disable();
idle_task_exit();
xics_teardown_cpu(0);
rtas_stop_self();
/* Should never get here... */
BUG();
for(;;);
}
so does that mean that CONFIG_HOTPLUG_CPU should also be used to
stop the complation of pSeries_mach_cpu_die() ?
--linas
More information about the Linuxppc-dev
mailing list