[PATCH 31/32] powerpc: Merge 32 and 64 bits asm-powerpc/io.h

Guennadi Liakhovetski g.liakhovetski at gmx.de
Mon Nov 13 07:38:26 EST 2006


On Sat, 11 Nov 2006, Benjamin Herrenschmidt wrote:

> +/* 32 bits uses slightly different variables for the various IO
> + * bases. Most of this file only uses _IO_BASE though which we
> + * define properly based on the platform
> + */
> +#ifdef CONFIG_PCI
> +#define _IO_BASE	0
> +#define _ISA_MEM_BASE	0
> +#define PCI_DRAM_OFFSET 0
> +#elif defined(CONFIG_PPC32)
> +#define _IO_BASE	isa_io_base
> +#define _ISA_MEM_BASE	isa_mem_base
> +#define PCI_DRAM_OFFSET	pci_dram_offset
> +#else
> +#define _IO_BASE	pci_io_base
> +#define _ISA_MEM_BASE	0
> +#define PCI_DRAM_OFFSET	0
> +#endif

As narrowed down by me during a git-bisect session, debugging non-working 
IDE on kuroboxHG with your patches applied, actually found by a modest IRC 
hero, wiching to remain incognito, and verified by me, that is a typo, it 
should have been

> +#ifndef CONFIG_PCI

Thanks
Guennadi
---
Guennadi Liakhovetski



More information about the Linuxppc-dev mailing list