build problems with powerpc allmodconfig
Judith Lebzelter
judith at osdl.org
Wed Nov 8 05:09:37 EST 2006
>> - vioscsi linkage fails because iseries_vscsi.c and rpa_vscsi.c.
>> This needs some trivial indirection via function vectors, but
>> how can we find out which one to use from the driver? Both
>> seem to look the same in the device tree
>
> The maintainer suggested that we just don't build vioscsi for iseries
> if we are building the rpa version as it is not often used (in particular,
> it is not used for installations). We could, however distinguish them
> by changing the "compat" field in the iSeries device tree if we wished.
>
How about just adding an 'ifndef' in the Makefile, as in the patch below?
This compiles ibmvscsic.o fine.
Judith Lebzelter
---
Index: linux/drivers/scsi/ibmvscsi/Makefile
===================================================================
--- linux.orig/drivers/scsi/ibmvscsi/Makefile 2006-11-06 16:52:09.000000000 -0800
+++ linux/drivers/scsi/ibmvscsi/Makefile 2006-11-07 09:35:34.019969437 -0800
@@ -1,7 +1,9 @@
obj-$(CONFIG_SCSI_IBMVSCSI) += ibmvscsic.o
ibmvscsic-y += ibmvscsi.o
+ifndef CONFIG_PPC_PSERIES
ibmvscsic-$(CONFIG_PPC_ISERIES) += iseries_vscsi.o
+endif
ibmvscsic-$(CONFIG_PPC_PSERIES) += rpa_vscsi.o
obj-$(CONFIG_SCSI_IBMVSCSIS) += ibmvstgt.o
More information about the Linuxppc-dev
mailing list