[PATCH 2/5] [RFC] Add support for lite5200b to arch/powerpc

[Grant Likely]

On 11/6/06, Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
>
> > +static int __init lite5200_probe(void)
> > +{
> > +     unsigned long node = of_get_flat_dt_root();
> > +     const char *model = of_get_flat_dt_prop(node, "model", NULL);
> > +
> > +     if (!of_flat_dt_is_compatible(node, "mpc52xx"))
> > +             return 0;
> > +     pr_debug("%s board w/ mpc52xx found\n", model ? model : "unknown");
> > +
> > +     return 1;
> > +}
>
> Are you creating a "generic" mpc52xx machine or a "lite5200b" machine ?
>
> If you do the former, it will try to match on any board with that
> compatible propery, thus any mpc52xx based board. That is probably not
> what you want.

Heh, I got lazy.  I'll fix this.

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195