[Alsa-devel] [RFC 4/7] snd-aoa: add codecs

[Takashi Iwai]

At Tue, 30 May 2006 15:39:09 +0200,
Johannes Berg wrote:
> 
> On Tue, 2006-05-30 at 15:35 +0200, Takashi Iwai wrote:
> 
> > And I thought the put callbacks in your code always return either 1 or
> > -err?
> 
> Yeah, they return 1 if the change was applied (or no change) and -err if
> there's an error about the change (only in very few cases).
> 
> I figured the extra notification wouldn't hurt, and to the application
> there wouldn't be a problem.

Actually the extra notification won't hurt much in practice.
I've seen that some drivers also don't check the unchanged case and
return always 1, so apparently the apps work.  But, it's of course
better to check the state on the driver side.


Takashi