[Alsa-devel] [RFC 5/7] snd-aoa: add layout-id fabric

Takashi Iwai tiwai at suse.de
Mon May 29 22:14:59 EST 2006


At Sun, 28 May 2006 21:00:31 +0200,
Johannes Berg wrote:
> 
> The 'fabric' is the thing that pulls all of snd-aoa together, this patch
> adds the 'layout' or 'layout-id' fabric that keys off the 'layout-id'
> property in the device-tree to pull in the proper modules. It itself loads
> if an i2sbus is present with a layout-id (exported in modalias) that it can
> use.
(snip)
> +static void use_layout(struct layout *l)
> +{
> +	int i;
> +
> +	for (i=0; i<MAX_CODECS_PER_BUS; i++) {
> +		if (l->codecs[i].name) {
> +			request_module("snd-aoa-codec-%s", l->codecs[i].name);

Just from curiosity:  Does this work properly?
I remember that there was a deadlock when you call request_module()
during module probe.


Takashi



More information about the Linuxppc-dev mailing list