[PATCH/2.6.17-rc4 1/10] Powerpc: Add general support for mpc7 448h pc2 (Taiga) platform

[Zang Roy-r61911]

> On Wed, 2006-05-17 at 08:45 -0500, Kumar Gala wrote:
> 
> > > +#ifdef TSI108_ETH
> > > +hw_info hw_info_table[TSI108_ETH_MAX_PORTS + 1] = {
> > > +	{TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET,
> > > +	 TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET,
> > > +	 TSI108_PHY0_ADDR, IRQ_TSI108_GIGE0},
> > > +
> > > +	{TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET + 0x400,
> > > +	 TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET,
> > > +	 TSI108_PHY1_ADDR, IRQ_TSI108_GIGE1},
> > > +
> > > +	{TBL_END, TBL_END, TBL_END, TBL_END}
> > > +};
> > > +#endif
> > 
> > This table looks problematic.  Look at using something like a  
> > platform device.
> 
> Bzzzt ... wrong answer :) That's a textbook example of stuff 
> that should
> be provided via the device-tree.
> 
> 

Well , should I register this data to a platform device or the Ethernet 
driver get the information from device-tree directly?
Roy