[PATCH] remove powerpc bitops infavor of existing generic bitops
jschopp
jschopp at austin.ibm.com
Tue May 16 06:42:10 EST 2006
> Ah but here's the trick, there is the same explicit call to ppc
> assembly. The only function in the file removed is this one you pointed
> out, and the only caller of this function is ext2_ffz. And the only
> user of ext2_ffz is find_next_zero_le_bit.
>
> Now the generic code is very similar to the file removed (`diff -Narup
> arch/powerpc/lib/bitops.c lib/find_next_bit.c` to see for yourself). In
> the same place where ext2_ffz is called, ffz is called in the generic
> code. Now if we look at the definition of ffz in
> include/asm-powerpc/bitops.h, we see it calls __ilog2 of that same file.
> __ilog2 is defined as:
>
> static __inline__ int __ilog2(unsigned long x)
> {
> int lz;
>
> asm (PPC_CNTLZL "%0,%1" : "=r" (lz) : "r" (x));
> return BITS_PER_LONG - 1 - lz;
> }
>
> So, its really the same code :)
Good explination. I'm convinced, so for what it's worth:
Acked-by: Joel Schopp <jschopp at austin.ibm.com>
More information about the Linuxppc-dev
mailing list