[PATCH 04/13] cell: remove broken __setup_cpu_be function
Paul Mackerras
paulus at samba.org
Fri May 5 16:03:14 EST 2006
Arnd Bergmann writes:
> From: Geoff Levand <geoffrey.levand at am.sony.com>
>
> This patch removes the incorrect Cell processor setup routine
> __setup_cpu_be. This routine improperly accesses the hypervisor
> page size configuration at SPR HID6. The correct behavior is for
> firmware, or if needed, platform setup code, to set the correct
> page size.
> - .cpu_setup = __setup_cpu_be,
> + .cpu_setup = __setup_cpu_power4,
That looks a bit dodgy. Either just remove the contents of
__setup_cpu_be (leaving only the blr), or define a __setup_cpu_null
that does nothing, or make the identify_cpu not call the cpu setup
function if the pointer is NULL.
Paul.
More information about the Linuxppc-dev
mailing list