DTC/dts modifications

Kumar Gala galak at kernel.crashing.org
Tue May 2 05:39:44 EST 2006


On May 1, 2006, at 2:33 PM, Jon Loeliger wrote:

> On Sat, 2006-04-29 at 11:00, Kumar Gala wrote:
>> All,
>>
>> What evilness would it be to change the use of '#' in the .dts format
>> to some other character like '$' or '%'.
>
> Uh, use of '#' for what?  Current comment style is
> either C or C++, ie, /* ... */ or //.

Comment aren't the issue.

>>   The problem is the use of
>> '#' prevents use from using cpp which would make some aspects of
>> building up .dts for boards far more useful.
>
> I think to get CPP to be usable, it will need to handle
> the # emitted line-location markers, "# <line> <file> <level>".

Don't follow you here.

>> We can easily provide a one line script to convert people's .dts to
>> the new format.
>
> I don't think there is a conversion necessary yet.
> Did I miss something here?

Try running a current .dts through cpp today.  You will get errors like:

oftree.dts:15:3: error: invalid preprocessing directive #address
oftree.dts:16:3: error: invalid preprocessing directive #size
oftree.dts:20:4: error: invalid preprocessing directive #cpus
oftree.dts:21:4: error: invalid preprocessing directive #address
oftree.dts:22:4: error: invalid preprocessing directive #size
oftree.dts:25:2: error: invalid preprocessing directive #foobar

Because of props like:

       #cpus = <1>;
       #address-cells = <1>;
       #size-cells = <0>;

If these used some other symbol instead of '#' cpp will be happy and  
we can use it to create macros for us.

- k




More information about the Linuxppc-dev mailing list