[PATCH] powerpc: Extends HCALL interface for InfiniBand usage

[Segher Boessenkool]

> below (and attached) you will find my ib_hcall patch, which extends
> the HCALL interface for InfiniBand usage. I've made the patch
> agains the lates Linux kernel snapshot (linux-2.6.16-git14) from
> kernel.org. We moved this into the common powerpc code based on
> comments we got after posting the first eHCA InfiniBand device
> driver patch.
>
> Any comments or proposals for my patch?

Looks good /an sich/, but...

>   #define H_Success    0
>   #define H_Busy        1    /* Hardware busy -- retry later */
>   #define H_Closed    2    /* Resource closed */
> +#define H_NOT_AVAILABLE    3
>   #define H_Constrained    4    /* Resource request constrained to  
> max allowed */
> +#define H_PARTIAL          5
>   #define H_InProgress   14    /* Kind of like busy */
> +#define H_PARTIAL_STORE   16
> +#define H_PAGE_REGISTERED 15

All the other defines use StudlyCaps, yours use SHOUTING_CAPS, you
might want to choose just one style (though I prefer the shouting one).

> diff -Nurpw linux-2.6.16-git14/arch/powerpc/platforms/pseries/ 
> hvCall.S.orig linux-2.6.16-git14-ib/arch/powerpc/platforms/pseries/ 
> hvCall.S.orig
> --- linux-2.6.16-git14/arch/powerpc/platforms/pseries/hvCall.S.orig	 
> 1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.16-git14-ib/arch/powerpc/platforms/pseries/ 
> hvCall.S.orig	2006-03-28 14:19:51.140018464 +0200

Erm...  you messed up here :-)

In fact, the patch is broken in more places, please make sure just to
diff the files you wanted to diff, and it looks like you posted two  
patches
in one?


Segher