[PATCH 5/11] powerpc: iseries: mf related cleanups

Stephen Rothwell sfr at canb.auug.org.au
Wed Mar 22 11:39:08 EST 2006


Hi Michael,

Just some small nits ...

On Tue, 21 Mar 2006 20:46:02 +1100 Michael Ellerman <michael at ellerman.id.au> wrote:
>
> +static int mf_initialized = 0;

We don't generally put the "= 0".

> +	mf_initialized = 1;
> +	mb();

Do we really need the mb().  If so, a comment saying why would be good. 
(Yes, I know that you are just moving code.)

Otherwise looks good.
-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20060322/ea0f2f64/attachment.pgp>


More information about the Linuxppc-dev mailing list