[PATCH] Fix MPC8548CDS rebooting procedure

Haruki Dai-r35557 Dai.Haruki at freescale.com
Thu Mar 9 06:24:30 EST 2006


> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> Sent: Wednesday, March 08, 2006 12:33 PM
> To: Haruki Dai-r35557
> Cc: linuxppc-dev at ozlabs.org
> Subject: Re: [PATCH] Fix MPC8548CDS rebooting procedure
> 
> 
> On Mar 8, 2006, at 11:22 AM, Haruki Dai-r35557 wrote:
> 
> > This patch fixes the MPC8548 CDS rebooting procedure.
> > Without this patche, issuing reboot from shell doesn't reboot the 
> > machine.
> >
> > Signed-off-by: Dai Haruki <dai.haruki at freescale.com>
> 
> Dai, I'm avoid taking patches for 85xx that effect new 
> functionality.  If you want change this to work with 
> arch/powerpc and make it a run time check for 8548.

Hi Kumar, what kind of new feature is affected by this bug fix? 8548
requires reboot to set the hardware reset bits. The mpc85xx_restart() is
not ported to arch/powerpc yet. Which portion of the arch/powerpc code
should be modified in order to restart the machine correctly? 
And how do you want me to do run time check? Check SVR? 

Dai 

> 
> - kumar
> 
> > ---
> >
> >  arch/ppc/syslib/ppc85xx_setup.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > 8f095006923385c3546165b0e10d73d3e057c120
> > diff --git a/arch/ppc/syslib/ppc85xx_setup.c 
> > b/arch/ppc/syslib/ppc85xx_setup.c index e4dda43..45b1b2b 100644
> > --- a/arch/ppc/syslib/ppc85xx_setup.c
> > +++ b/arch/ppc/syslib/ppc85xx_setup.c
> > @@ -115,6 +115,11 @@ mpc85xx_early_serial_map(void)  void  
> > mpc85xx_restart(char *cmd)  {
> > +#ifdef CONFIG_MPC8548
> > +	volatile unsigned int *rstcr;
> > +	u32 *pMem = (u32*) ioremap((BOARD_CCSRBAR + 0xe00b0),0x100);
> > +	*pMem = 0x2; /* Set HRESET_REQ flag */ #endif
> >  	local_irq_disable();
> >  	abort();
> >  }
> > --
> > 1.2.4
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev at ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
> 
> 



More information about the Linuxppc-dev mailing list