[RFC] I2C-MPC: Fix up error handling

Jean Delvare khali at linux-fr.org
Mon Jul 31 16:57:24 EST 2006


> > Quoting myself:
> > > Could anyone please comment on this i2c-mpc patch, and give it some
> > > testing on different systems? I'm fine with the error propagation
> > > fixes, but less fine with the random resets being added, and rather
> > > unhappy with the "retry once more just in case" thing, which I think,
> > > if really needed, should instead be implemented using the standard
> > > i2c_adapter.retries mechanism.
> >
> > Can anyone please comment on this patch? Andrew Morton keeps  
> > forwarding it to me, but I don't think I can accept it as is (see
> > my complaints above.)
> 
> If I find some time, let me split out the error propagation so we can  
> get that fix up stream.  The other code was to handle a buggy device  
> that was connected in one system I was working on.

Sounds like a good plan, thanks.

-- 
Jean Delvare



More information about the Linuxppc-dev mailing list