[linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[Kumar Gala]

On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:

> Another one in header file.
>
> ---
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 679c1cd..8da2774 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -642,7 +642,7 @@ #endif
>
>
> / 
> *--------------------------------------------------------------------- 
> -
> ---*/
>
> -#ifdef CONFIG_PPC_83xx
> +#ifdef CONFIG_MPC834x
>  /* Some Freescale processors have an erratum in which the TT
>   * port number in the queue head was 0..N-1 instead of 1..N.
>   */

Do we really want to make this change.  What harm is there in having  
the ehci support for MPC834x build on all 83xx processors?  I can't  
imagine we are going to config in support for ehci on anything that  
is MPC834x at this point and if you do, your device tree isn't going  
to have nodes in it so the drivers not going to bind against anything.

Finally, I got to believe Freescale's going to build some MPC83xx in  
the future with the high speed USB IP.

- kumar

>
>> -----Original Message-----
>> From: linux-usb-devel-bounces at lists.sourceforge.net
>> [mailto:linux-usb-devel-bounces at lists.sourceforge.net] On Behalf Of
> Kumar Gala
>> Sent: Friday, July 14, 2006 9:52 PM
>> To: Li Yang-r58472
>> Cc: linuxppc-dev at ozlabs.org; gregkh at suse.de;
>> linux-usb-devel at lists.sourceforge.net
>> Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB
> hostdependency
>>
>> Acked-by: Kumar Gala <galak at kernel.crashing.org>
>>
>> On Jul 14, 2006, at 6:58 AM, Li Yang wrote:
>>
>>> The high-speed USB SOC only exists on MPC834x family not MPC83xx
>>> family.
>>>
>>> Signed-off-by: Li Yang <leoli at freescale.com>
>>>
>>> ---
>>>
>>>  drivers/usb/host/ehci-hcd.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-
>>> hcd.c index 79f2d8b..3af1844 100644
>>> --- a/drivers/usb/host/ehci-hcd.c
>>> +++ b/drivers/usb/host/ehci-hcd.c
>>> @@ -892,7 +892,7 @@ #include "ehci-pci.c"
>>>  #define	EHCI_BUS_GLUED
>>>  #endif
>>>
>>> -#ifdef CONFIG_PPC_83xx
>>> +#ifdef CONFIG_MPC834x
>>>  #include "ehci-fsl.c"
>>>  #define	EHCI_BUS_GLUED
>>>  #endif
>