[PATCH 001/001 Updated again] PMAC HD runtime blinking control
Cedric Pradalier
cedric.pradalier at inrialpes.fr
Wed Jan 25 22:27:02 EST 2006
According to Andreas Schwab, on Wed, 25 Jan 2006 12:06:44
+0100,
>Cedric Pradalier <cedric.pradalier at inrialpes.fr> writes:
>
>> @@ -427,6 +432,15 @@ static void pmac_ide_kauai_selectproc(id
>>
>> #ifdef CONFIG_BLK_DEV_IDE_PMAC_BLINK
>>
>> +MODULE_AUTHOR("Paul Mackerras & Ben. Herrenschmidt");
>> +MODULE_DESCRIPTION("Support for IDE interfaces on PowerMacs");
>> +MODULE_LICENSE("GPL");
>> +
>> +static int activity_led = 0;
>
>No need to zero-initialize a static variable.
On the other hand, the cost is minor for an increased
readability and a behavior which does not rely on any
assumption on the compiler (or even the C specification).
I tend to favor readability first in my coding.
Cheers
--
Cedric
More information about the Linuxppc-dev
mailing list