[PATCH 001/001 Updated] PMAC HD runtime blinking control

Cedric Pradalier cedric.pradalier at inrialpes.fr
Tue Jan 24 08:31:33 EST 2006

According to Benjamin Herrenschmidt, on Tue, 24 Jan 2006
00:47:16 +1100, 
>> The key I could not understand was that hwif->gendev is
>> only initialised in the probe. So I had to move the
>> device creation after that.
>> Currently, it is blinking by default. Should it be that
>> way? I guess so, since it is activated by a kernel config
>> option. It is easy to change if required.
>Yes. In fact, by enabled default for ATA disks and by disabled for ATAPI
>would make sense...

How do I tell the difference?. There is a 'kind' in pmif,
and also a atapi_dma flag in hwif. Which is more sensible?

>Also, we should think a bit about the file name... "blinking_led" isn't
>terrific for something that will end up in a non-ppc specific location.
>Or maybe on the contrary it's good ... what about "activity_led"
>rather ?

I'm open to any suggestion. I'll wait a bit to see if
someone else has a comment, then I'll change to


More information about the Linuxppc-dev mailing list