[PATCH] sound/ppc/pmac.c typo.

Stelian Pop stelian at popies.net
Fri Jan 20 21:35:38 EST 2006


In 2.6.16-rc1 there is a small typo introduced by the 'Remove device_node addrs/n_addr' changes
which prevents my Powerbook G4 sound from working:

	Advanced Linux Sound Architecture Driver Version 1.0.11rc2 (Wed Jan 04 08:57:20 2006 UTC).
	snd: can't request rsrc  0 (Sound Control: 0x80000000:80004fff)
	ALSA device list:
	   No soundcards found.

The patch below fixes it. Of course, the patch fixing the i2c issues 
('i2c_smbus_write_i2c_block_data' patch) needs to be applied to in order for
the sound to completly work.
 
Signed-off-by: Stelian Pop <stelian at popies.net>

diff -r ad1abd4058ea sound/ppc/pmac.c
--- a/sound/ppc/pmac.c	Fri Jan 20 11:02:26 2006 +0100
+++ b/sound/ppc/pmac.c	Fri Jan 20 11:13:55 2006 +0100
@@ -1217,7 +1217,7 @@
 			goto __error;
 		}
 		for (i = 0; i < 3; i ++) {
-			if (of_address_to_resource(np->parent, i,
+			if (of_address_to_resource(np, i,
 						   &chip->rsrc[i])) {
 				printk(KERN_ERR "snd: can't translate rsrc "
 				       " %d (%s)\n", i, rnames[i]);


-- 
Stelian Pop <stelian at popies.net>




More information about the Linuxppc-dev mailing list