[PATCH] powerpc: Add FSL SOC library and setup code

Olof Johansson olof at lixom.net
Sun Jan 15 18:15:33 EST 2006

On Sat, Jan 14, 2006 at 03:47:54PM -0800, Eugene Surovegin wrote:
> On Sat, Jan 14, 2006 at 01:21:58PM -0600, Olof Johansson wrote:
> > > +
> > > +static phys_addr_t immrbase = -1;
> > 
> > What does immr mean? Maybe a short comment would be good.
> IMHO, this is not needed because _everybody_ who is working 
> with these chips know what IMMR means. And there cannot be _any_ 
> confusion about it. Let's not add useless comments.

I haven't been exposed much yet to embedded 32-bit PPC, I thought at
first that it was something chip-specific, not an architected feature
common across the families. I agree, it doesn't really need further
explanation in this case.


More information about the Linuxppc-dev mailing list