[PATCH] powerpc: Fix PowerMac sound i2c
benh at kernel.crashing.org
Sun Feb 5 09:56:02 EST 2006
On Sat, 2006-02-04 at 18:26 +0000, Paul Collins wrote:
> Hi Ben,
> Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> > My patch reworking the PowerMac i2c code break the sound drivers as they
> > used to rely on some broken behaviour of i2c-keywest that is gone now.
> > This patch should fix them (tested on a g5 with alsa only). It might
> > also fix an oops if the alsa driver hits an unsupported chip.
> Applied Linus's current git tree, this patch makes ALSA sound on my
> PowerBook5,4 work again. The second patch does not work because the
> i2c wrapper (I assume that's what i2c_smbus_write_i2c_block_data is)
> has apparently not yet returned.
> It would be nice to have this fix in 2.6.16 if possible.
The second patch is the one that should go in, but it relies on an i2c
fix (undoing some Bunk damage) that is still staging in Greg tree... I
don't know what's up with that, I'll ask around.
More information about the Linuxppc-dev