[PATCH] Do not write virq back to PCI config space.
Benjamin Herrenschmidt
benh at kernel.crashing.org
Thu Dec 28 14:02:58 EST 2006
On Wed, 2006-12-27 at 20:46 -0600, Michal Ostrowski wrote:
> - Drivers will not rely on the PCI config space value, as they've
> already been conditioned to rely on the irq field in "struct pci_dev".
>
> - The virq value may not be < 256 as it has been remapped.
>
> - The PCI config space should reflect the hardware configuration, which
> is not being changed. We are only creating a virtual irq mapping that
> exists in the kernel only. One would never expect the PCI hardware to
> generate the "virq" interrupt.
>
> Signed-off-by: Michal Ostrowski <mostrows at watson.ibm.com>
Can you fix 32 bits too ?
Ben.
> ---
> arch/powerpc/kernel/pci_64.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c
> index 9bae8a5..81a73fb 100644
> --- a/arch/powerpc/kernel/pci_64.c
> +++ b/arch/powerpc/kernel/pci_64.c
> @@ -1305,7 +1305,6 @@ int pci_read_irq_line(struct pci_dev *pci_dev)
> DBG(" -> mapped to linux irq %d\n", virq);
>
> pci_dev->irq = virq;
> - pci_write_config_byte(pci_dev, PCI_INTERRUPT_LINE, virq);
>
> return 0;
> }
More information about the Linuxppc-dev
mailing list