[PATCH] powerpc: consolidate mpc83xx platform files

[Stephen Rothwell]

Hi Olaf,

On Fri, 15 Dec 2006 11:59:02 -0600 Olof Johansson <olof at lixom.net> wrote:
>
> +static int __init genrtc_rtc_hookup(void)
> +{
> +	/* Don't init if the platform has already set up rtc functions. */
> +	if (ppc_md.get_rtc_time || ppc_md.set_rtc_time)
> +		return -1;

If this is considered not an error, then please return -ENODEV so that if
initcall_debug is set, the kernel won't consider this worth noting.

> +	rtc_dev = rtc_class_open("rtc0");
> +
> +	if (!rtc_dev) {
> +		printk("genrtc_rtc_hookup: Failed to open rtc0\n");

KERN_ERR?

> +		return -1;

init routines should return 0/-<errno number> so that initcall_debug is
useful.  Though what Evalue is appropriate here I don't know.

--
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20061216/04a10557/attachment.pgp>