[PATCH 6/15] hypervisor console driver for Celleb

Ishizaki Kou kou.ishizaki at toshiba.co.jp
Tue Dec 12 22:30:04 EST 2006


> On Tue, 2006-12-12 at 15:53 +1100, Benjamin Herrenschmidt wrote:
> > On Tue, 2006-12-12 at 15:13 +1100, Michael Ellerman wrote:
> > > On Tue, 2006-12-12 at 13:02 +0900, Ishizaki Kou wrote:
> > > > op_model_cell supports native Cell processor. Under LPAR environment,
> > > > it cannot work.
> > > > 
> > > > Signed-off-by: Kou Ishizaki <kou.ishizaki.co.jp>
> > > > ---
> > > > 
> > > > Index: linux-powerpc-git/arch/powerpc/oprofile/common.c
> > > > diff -u linux-powerpc-git/arch/powerpc/oprofile/common.c:1.1.1.1 linux-powerpc-git/arch/powerpc/oprofile/common.c:1.2
> > > > --- linux-powerpc-git/arch/powerpc/oprofile/common.c:1.1.1.1	 Wed Dec  6 08:25:43 2006
> > > > +++ linux-powerpc-git/arch/powerpc/oprofile/common.c		 Wed Dec  6 08:43:15 2006
> > > > @@ -149,6 +149,8 @@
> > > >  #ifdef CONFIG_PPC64
> > > >  #ifdef CONFIG_PPC_CELL_NATIVE
> > > >			case PPC_OPROFILE_CELL:
> > > > +			if (firmware_has_feature(FW_FEATURE_LPAR))
> > > > +					return -ENODEV;
> > > >							model = &op_model_cell;
> > > >								break;
> > > >  #endif
> > > 
> > > Is FW_FEATURE_LPAR is the right switch to use here, I'm not sure.
> > 
> > For now, it probably is as none of the LPAR env. for cell work with that
> > op_model.
> 
> Sure, there's probably twenty different things we could use at the
> moment, I'm just wondering out loud if LPAR is the best thing to reduce
> the chance we have to change it in the future.

We will implement Cell LPAR support in the future. The code doesn't
exist now, and it tries to use oprofile_timer by returning -ENODEV
here.
				   
Thank you,
Kou Ishizaki
Toshiba



More information about the Linuxppc-dev mailing list