[POWERPC] fix cell pmu initialisation

Michael Ellerman michael at ellerman.id.au
Wed Dec 6 09:21:56 EST 2006


On Wed, 2006-12-06 at 07:07 +1100, Benjamin Herrenschmidt wrote:
> > 1. export a method from cbe_regs.c to find out whether the pmd 
> >    regs are available and test that in cbe_init_pm_irq().
> > 2. take you patch as is, with a comment hinting to fix it up
> >    when needed.
> > 3. change cbe_init_pm_irq to be called explicitly from cbe_regs_init(),
> >    which already scans the device tree correctly.
> 
> cbe_regs_init() is called from setup_arch(), which is _very_ early.
> 
> cbe_init_pm_irq() must be called much later as it requests irqs.
> 
> Right now, we should stick to the machine_is() solution. We'll look into
> doing something better eventually when the need occurs.

4. Add a FIRMWARE_FEATURE for it.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20061206/be4898ee/attachment.pgp>


More information about the Linuxppc-dev mailing list