powerpc virq: new routine virq_to_hw

Segher Boessenkool segher at kernel.crashing.org
Mon Aug 28 17:16:06 EST 2006


> I'd much prefer:
>
> static inline irq_hw_number_t virq_to_hw (unsigned int virq)
> {
> 	return irq_map[virq].hwirq;
> }
>
> I've grown to dislike the CR between the return type and the function
> name (I used to do that too) and it seems that this opinion is  
> shared by
> Linus (there was an old thread on lkml about it).

And while we're at it: no space before parenthesis in a function
declaration/definition.


Segher




More information about the Linuxppc-dev mailing list