[PATCH 2/2] uninorth: Add module param 'aperture' for aperture size

Michel Dänzer michel at tungstengraphics.com
Wed Aug 23 19:14:41 EST 2006

On Wed, 2006-08-23 at 08:17 +1000, Benjamin Herrenschmidt wrote:
> > > It's basically expected that we set it ourselves and a module option 
> > > doesn't seem like a terribly good idea to me...
> > 
> > Well, wasn't it you who suggested this? :)
> Possibly, I don't always have good ideas :) I would rather have that
> size be configured by the client driver... 

That would certainly be ideal. Digging into the code a little deeper, it
seems like the backend's insert_memory hook should be able to adjust the
GATT table size on the fly. Not sure __get_free_pages() is expected to
succeed for dozens of pages at any given time though.

> oh well, let's workaround that for now by using a better default _and_ 
> the module option.

Agreed, I'll re-send the patch with the default changed to 64M.

Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer

More information about the Linuxppc-dev mailing list