[PATCH] Add 85xx DTS files to powerpc
Sergei Shtylyov
sshtylyov at ru.mvista.com
Sun Aug 20 04:27:13 EST 2006
Hello.
Andy Fleming wrote:
> Added the mpc85xx family of dts files to the powerpc tree
> ---
> arch/powerpc/boot/dts/mpc8540ads.dts | 257 ++++++++++++++++++++++++++++++
> arch/powerpc/boot/dts/mpc8541cds.dts | 244 +++++++++++++++++++++++++++++
> arch/powerpc/boot/dts/mpc8548cds.dts | 287 ++++++++++++++++++++++++++++++++++
> arch/powerpc/boot/dts/mpc8555cds.dts | 244 +++++++++++++++++++++++++++++
> 4 files changed, 1032 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8540ads.dts b/arch/powerpc/boot/dts/mpc8540ads.dts
> new file mode 100644
> index 0000000..93d2c2d
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mpc8540ads.dts
[...]
> + ethernet-phy at 2 {
> + linux,phandle = <2452002>;
> + interrupt-parent = <40000>;
> + interrupts = <37 1>;
> + reg = <2>;
> + device_type = "ethernet-phy";
> + };
Well, there's PHYs #2 and #3 on the board, #2 is probably not tied to
anything though.
> + ethernet at 26000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + device_type = "network";
> + model = "TSEC";
> + compatible = "gianfar";
> + reg = <26000 1000>;
> + address = [ 00 E0 0C 00 73 02 ];
> + local-mac-address = [ 00 E0 0C 00 73 02 ];
> + interrupts = <19 2>;
> + interrupt-parent = <40000>;
> + phy-handle = <2452002>;
> + };
Shouldn't it be "FEC" instead? The third controller is actually Fast
Ethernet and fsl_soc.c differs TSEC and FEC WRT the interrupts (FEC has only
one). So, this entry looks incorrect...
> + pic at 40000 {
> + linux,phandle = <40000>;
> + clock-frequency = <0>;
> + interrupt-controller;
> + #address-cells = <0>;
> + #interrupt-cells = <2>;
> + reg = <40000 40000>;
> + built-in;
> + compatible = "chrp,open-pic";
> + device_type = "open-pic";
> + big-endian;
Spaces instead of tabs in this line...
> + };
> + };
> +};
WBR, Sergei
More information about the Linuxppc-dev
mailing list