[PATCH] Fix IRQ handling on MPC8540 ADS

[Andy Fleming]

On Aug 18, 2006, at 13:37, Sergei Shtylyov wrote:

> Hello.
>
> Andy Fleming wrote:
>> * Fixed IRQ handling for the 85xx ADS boards so it uses the new
>>   generic irq stuff
>> * Fixed PCI IRQ mapping so it comes from the device tree
>
>    NAK. The kernel doesn't build with this patch. I'm getting this:
>
>   CC      arch/powerpc/platforms/85xx/mpc85xx_ads.o
> arch/powerpc/platforms/85xx/mpc85xx_ads.c: In function  
> `mpc85xx_ads_pic_init':
> arch/powerpc/platforms/85xx/mpc85xx_ads.c:76: warning: implicit  
> declaration of
> function `of_put_node'
>
>   and then finally:

Argh.  In my rush to get these patches out, I neglected to test the  
8540 ADS, and forgot that I added a few lines for "robustness".  I  
will fix and resubmit after testing.

>
>   LD      .tmp_vmlinux1
> arch/powerpc/platforms/built-in.o(.init.text+0x26c): In function  
> `mpc85xx_ads_pic_init':
> arch/powerpc/platforms/85xx/mpc85xx_ads.c:84: undefined reference  
> to `of_put_node'
> arch/powerpc/platforms/built-in.o(.init.text+0x404):arch/powerpc/ 
> platforms/85xx/mpc85xx_ads.c:76: undefined reference to `of_put_node'
> make: *** [.tmp_vmlinux1] Error 1
>
>    There's no such function in the kernel -- it actually aclled  
> of_node_put(). I can post an updated patch after testing (if it  
> succeeds) if you like...
>
>> This patch *really* needs to go in before 2.6.18 is final, else  
>> 2.6.18 doesn't build for 85xx.
>
>    Looks like it's a bit crude yet to be committed...

Agreed, though it's actually no worse than the current mainline!

>
>> Thanks,
>> Andy
>
> WBR, Sergei