[PATCH 02/13] IB/ehca: includes

Christoph Raisch RAISCH at de.ibm.com
Sat Aug 19 01:35:54 EST 2006


> > +#define EDEB_P_GENERIC(level,idstring,format,args...) \
> These macros are responsible for 61% of the object code size of your
> ...Please get rid of that crap entirely and replace
> it with dev_info/dev_dbg/dev_warn calls where appropriate!
>    Arnd <><

we'll change these EDEBs to a wrapper around dev_err, dev_dbg and dev_warn
as it's done in the mthca driver.
All EDEB_EN and EDEB_EX will be removed, that type of tracing can be done
if needed by kprobes.
There are a few cases where we won't get to a dev, for these few places
we'll use a simple wrapper around printk, as done in ipoib.

Hope that's the "official" way how to implement it in ib drivers.

Gruss / Regards . . . Christoph R

More information about the Linuxppc-dev mailing list