[PATCH 4/6] POWERPC: add support of mpc8560 eval board

[Segher Boessenkool]

>> +		pic at 40000 {
>> +			linux,phandle = <40000>;
>> +			interrupt-controller;
>> +			#address-cells = <0>;
>> +			#interrupt-cells = <2>;
>> +			reg = <40000 20100>;
>> +			built-in;
>> +			device_type = "mpic";
>
> This is wrong.  It should be "open-pic";

Not necessarily; if not, it should have "open-pic" somewhere
in the "compatible" property though.

Best might be to have device_type = interrupt-controller,
and put "mpic,open-pic" in the "compatible" property (no
comma but a zero byte...)

Or prefix it with the name of your _exact_ interrupt controller,
even.


Segher