[PATCH 3/6] ehea: queue management
    Alexey Dobriyan 
    adobriyan at gmail.com
       
    Fri Aug 11 10:32:04 EST 2006
    
    
  
> > +static inline u32 map_swqe_size(u8 swqe_enc_size)
> > +{
> > +	return 128 << swqe_enc_size;
> > +}		      ^
> > +		      |
> > +static inline u32|map_rwqe_size(u8 rwqe_enc_size)
> > +{		      |
> > +	return 128 << rwqe_enc_size;
		      ^
> > +}		      |
>		      |
> Snap!  These are ide|tical...
		      |
No, they aren't. -----+
> Name the function after what it does, not after the functions you expect
> to call it.
    
    
More information about the Linuxppc-dev
mailing list