[PATCH] Convert to mac-address for ethernet MAC address data.

Jon Loeliger jdl at freescale.com
Fri Aug 4 07:55:43 EST 2006


On Thu, 2006-08-03 at 16:49, Kumar Gala wrote:

> >
> > -		mac_addr = get_property(np, "address", NULL);
> > -		memcpy(gfar_data.mac_addr, mac_addr, 6);
> > +		mac_addr = get_property(np, "local-mac-address", NULL);
> 
> If "mac-address" the preferred mechanism, why dont we check for it  
> first?

It's not.  "local-mac-address" is.  But that is HW specific.
SW version comes in as "mac-address".  Here's what was said
earlier by Paul Nasrat:

    Well I'm biased and say we shouldn't reinvent the wheel
    with dtc if we don't need to.  I've sent Jon a patch to
    start validating this for dtc and am waiting feedback
    before I add additional device_types. So we should have
    local-mac-address be preassiged hwaddr and mac-address last
    used. For some setups this would be the same persistently,
    but I can envisage some non OF setups populating mac-address
    from the card. 

    Paul

Which I interpreted to mean the order: local-mac-address first,
mac-address next, and the obsolete one, "address" last.

jdl




More information about the Linuxppc-dev mailing list