[PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg

Mark A. Greer mgreer at mvista.com
Thu Aug 3 03:00:32 EST 2006


On Wed, Aug 02, 2006 at 02:41:23PM +0200, Arnd Bergmann wrote:
> On Wednesday 02 August 2006 06:53, Paul Mackerras wrote:
> > > +#ifdef __powerpc64__
> > > +typedef unsigned long                u64;
> > > +#else
> > > +typedef unsigned long long   u64;
> > > +#endif
> > 
> > This is potentially confusing, because the __powerpc64__ relates to
> > the boot wrapper not the kernel, and we don't build a 64-bit boot
> > wrapper on any platform (not yet anyway).  Maybe this needs a comment.
> > 
> Moreover, even if we ever build this on __powerpc64__, the 
> typedef unsigned long long u64 would still do the right thing.
> It only ever becomes a problem when mixing with u64 the c99 uint64_t,
> which is defined the other way.

I copied that code from somewhere but I forget where & can't seem to
find it now.  I'll get rid of it for now.

Mark



More information about the Linuxppc-dev mailing list