[PATCH] crash in aty128_set_lcd_enable on PowerBook

[Antonino A. Daplas]

Olaf Hering wrote:
>  On Sun, Jul 16, Olaf Hering wrote:
> 
>> Current Linus tree crashes in aty128_set_lcd_enable() because par->pdev
>> is NULL. This happens since at least a week. Call trace is:
>>
>> aty128_set_lcd_enable
>> aty128fb_set_par
>> fbcon_init
>> visual_init
>> take_over_console
>> fbcon_takeover
>> notifier_call_chain
>> blocking_notifier_call_chain
>> register_framebuffer
>> aty128fb_probe
>> pci_device_probe
>> bus_for_each_dev
>> driver_attach
>> bus_add_driver
>> driver_register
>> __pci_register_driver
>> aty128fb_init
>> init
>> kernel_thread
>>
> 
> 
> - info->fix was assigned twice.
> - par->vram_size is assigned in aty128_probe(), no need to redo it again in aty128_init()
> - register_framebuffer() uses uninitialized struct members,
>   move it past par->pdev assignment and past aty128_bl_init().
> 
> 

Looks good.

> Signed-off-by: Olaf Hering <olh at suse.de>
Acked-by: Antonino Daplas <adaplas at pol.net>