[RFC , PATCH] support for the ibm,pa_features cpu property

Stephen Rothwell sfr at canb.auug.org.au
Sat Apr 29 12:38:29 EST 2006


Hi Paul,

On Sat, 29 Apr 2006 12:20:42 +1000 Paul Mackerras <paulus at samba.org> wrote:
>
> +	/* find descriptor with type == 0 */
> +	for (;;) {
> +		if (tablelen < 3 || tablelen < 2 + pa_feature_table[1])
                                                                    ^
Shouldn't that be 0?

> +			goto out;	/* not found */
> +		if (pa_feature_table[0] == 0)
                                     ^
And this 1?

> +			break;
> +		tablelen -= 2 + pa_feature_table[1];
                                                 ^
0

> +		pa_feature_table += 2 + pa_feature_table[1];
                                                         ^
0

> +	}
> +
> +	/* check if the specifier is long enough */
> +	if (pabyte >= pa_feature_table[1])
                                       ^
0

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20060429/82ecc897/attachment.pgp>


More information about the Linuxppc-dev mailing list