[PATCH 00/15] powerpc: move some header files

Kumar Gala galak at kernel.crashing.org
Thu Apr 6 02:15:04 EST 2006


On Apr 5, 2006, at 11:03 AM, Stephen Rothwell wrote:

> On Wed, 5 Apr 2006 09:28:55 -0500 Kumar Gala  
> <galak at kernel.crashing.org> wrote:
>>
>> How about we do the following to remove the include hack:
>>
>> don't move the following (determine what needs them to build and
>> fixup, I dont believe any of these need to exist at this point in
>> arch/powerpc for it to build any supported arch/powerpc platform:
>
> I only moved the files that were actually required to build the  
> defconfigs
> for the three 32 bit builds in arch/powerpc ...
>
>>   b/include/asm-powerpc/amigappc.h  |    9 ++----
>>   b/include/asm-powerpc/bootinfo.h  |    8 ++---
>>   b/include/asm-powerpc/mpc8xx.h    |   10 +++---
>>   b/include/asm-powerpc/ocp.h       |    7 ++--
>>   b/include/asm-powerpc/ocp_ids.h   |    6 ++--
>>   b/include/asm-powerpc/open_pic.h  |   10 +++---
>
> So maybe I could attempt to remove the dependencies instead of  
> moving the
> files.  You are right that it is worth it if we can just get rid of  
> these
> files.
>
>> Duplicate these headers (then I'll go through and clean them up,
>> removing arch/ppc'ism):
>>
>>   b/include/asm-powerpc/mpc83xx.h   |    7 ++--
>>   b/include/asm-powerpc/mpc85xx.h   |    9 ++----
>
> I guess that would work, but Paulus is going to not like me as he  
> already
> put all these patches into the powerpc tree.  :-)

That's Paulus own doing for his premature pull :)

> Something to keep me entertained for another day.

I'm guessing you had to pull some of them in because of the following:

io.h:#include <asm-ppc/io.h>
mmu_context.h:#include <asm-ppc/mmu_context.h>
mmu.h:#include <asm-ppc/mmu.h>
pci-bridge.h:#include <asm-ppc/pci-bridge.h>
pgalloc.h:#include <asm-ppc/pgalloc.h>
pgtable.h:#include <asm-ppc/pgtable.h>

I think addressing these will make life easier with the other includes.

- kumar




More information about the Linuxppc-dev mailing list