[PATCH 2/2] Base pSeries PCIe support
Paul Mackerras
paulus at samba.org
Sat Apr 1 19:38:45 EST 2006
Jake Moilanen writes:
> +property_present(struct device_node *np, const char *name)
> +{
> + struct property *pp;
> +
> + read_lock(&devtree_lock);
> + for (pp = np->properties; pp != 0; pp = pp->next)
> + if (strcmp(pp->name, name) == 0) {
> + return 1;
Ummm, did you mean to return with the devtree_lock held? I suspect
not. In any case, why not just use get_property or of_find_property?
Paul.
More information about the Linuxppc-dev
mailing list