PATCH Merge more include files

Jon Loeliger jdl at freescale.com
Wed Sep 7 06:46:38 EST 2005


On Fri, 2005-09-02 at 08:38, Kumar Gala wrote:
> On Sep 1, 2005, at 10:18 PM, Arnd Bergmann wrote:
> 
> > On Dunnersdag 01 September 2005 22:51, Jon Loeliger wrote:
> >
> >> +/*
> >> + * This file is included by 'init/main.c' to check for
> >> + * architecture-dependent bugs.
> >> + */
> >> +
> >> +extern void check_bugs(void);
> >> +
> >>
> >
> > Actually, I think this could to be
> >
> > +static inline void check_bugs(void)
> > +{
> > +}
> >
> > The function is empty on both ppc and ppc64, so we can just as
> > well get rid of the symbol as well.
> > The rest of the patch looks perfect to me.
> 
> We just have to make sure to get ride of the implementation in arch/ 
> ppc*/kernel/syscalls.c if we do this.
> 
> - kumar

Arnd,

If you'd like, I'll submit a patch to use the static inline
variant and rip out the definiton in the syscalls.c files.

jdl





More information about the Linuxppc-dev mailing list