2.6.13-rc7-git2 crashes on iBook

Daniel Drake dsd at gentoo.org
Fri Sep 2 05:26:28 EST 2005


Hi,

Stelian Pop wrote:
> Confirmed on an Apple Powerbook too.
> 
> For reference, the (already reverted) patch which needs to be applied is
> below.
> 
> Signed-off-by: Stelian Pop <stelian at popies.net>
> 
> Index: linux-2.6.git/drivers/pci/setup-res.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/pci/setup-res.c	2005-08-29 10:03:00.000000000 +0200
> +++ linux-2.6.git/drivers/pci/setup-res.c	2005-08-29 12:23:20.980716336 +0200
> @@ -53,9 +53,7 @@
>  	if (resno < 6) {
>  		reg = PCI_BASE_ADDRESS_0 + 4 * resno;
>  	} else if (resno == PCI_ROM_RESOURCE) {
> -		if (!(res->flags & IORESOURCE_ROM_ENABLE))
> -			return;
> -		new |= PCI_ROM_ADDRESS_ENABLE;
> +		new |= res->flags & IORESOURCE_ROM_ENABLE;
>  		reg = dev->rom_base_reg;
>  	} else {
>  		/* Hmm, non-standard resource. */
> 

Sorry for my ignorance. Which tree was this reverted in? You are probably 
aware that this bug made it into 2.6.13 (patch was not reverted there).

Daniel



More information about the Linuxppc-dev mailing list