Makefile check for older binutils broken?

[Andreas Schwab]

Marcelo Tosatti <marcelo.tosatti at cyclades.com> writes:

> Anyway, surrounding the verification command around an eval expression
> does the trick correcting the situation. Is it any good? 

Not at all.  You have effectively disabled the check completely.

> diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
> index 0432a25..cdd9250 100644
> --- a/arch/ppc/Makefile
> +++ b/arch/ppc/Makefile
> @@ -126,7 +126,7 @@ checkbin:
>  			false; \
>  		fi ; \
>  	fi
> -	@if ! /bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; then \
> +	@if ! [[ "/bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1" ]] ; then \

A non-empty string is always true.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab at suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."