[PATCH 2.6.14-rc5 1/1] : mv643xx_eth_showsram: Added information message when using the SRAM
Dale Farnsworth
dale at farnsworth.org
Wed Oct 26 04:30:04 EST 2005
On Tue, Oct 25, 2005 at 07:31:35AM +0000, Nicolas DET wrote:
> Added information message when using the SRAM in mv643xx_eth_probe()
>
> Signed-off-by: Nicolas DET <det.nicolas at free.fr>
> Signed-off-by: Sven Luther <sl at bplan-gmbh.de>
>
> diff -Naur a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> --- a/drivers/net/mv643xx_eth.c 2005-10-25 09:24:57.952386000 +0200
> +++ b/drivers/net/mv643xx_eth.c 2005-10-25 09:25:02.220386000 +0200
> @@ -1533,6 +1533,9 @@
> printk(KERN_NOTICE "%s: RX NAPI Enabled \n", dev->name);
> #endif
>
> + if (mp->tx_sram_size > 0)
> + printk(KERN_NOTICE "%s: Using SRAM\n", dev->name);
> +
> return 0;
>
> out:
Do you really think this is necessary? I think this driver is already
too verbose and we should be remove messages, not add them. :)
-Dale
More information about the Linuxppc-dev
mailing list