[PATCH] dmasound_pmac depends on pmac specific config options

Brad Boyer flar at allandria.com
Sun Oct 23 07:01:22 EST 2005

On Sat, Oct 22, 2005 at 09:46:26PM +0200, Olaf Hering wrote:
> dmasound_pmac should depend on pmac specific .config options.
> Since PMAC is always defined, but PMAC wont boot without either
> CUDA or PMU, one of these options indicates that the kernel is
> for a PowerMac.
> CONFIG_PM can be selected unconditionally.

I disagree. I think a much better solution would be to change the
code to be conditionalized internally on PMU support, rather than
having #ifdef CONFIG_PM since the functions being called inside
that protection are actually out of the PMU code, not the generic
power management system. By doing this, you could for example
have a kernel compiled for a 1st gen PCI PowerMac without any
extra drivers. In this case, you have CUDA and AWACS, but there
is no PMU support and no need for sleep notifiers.

Similar comments on the other patch.

	Brad Boyer
	flar at allandria.com

More information about the Linuxppc-dev mailing list