[PATCH 2.6.14-rc3 1/1] chrp_pegasos_eth: Added Marvell Discovery II SRAM support

Dale Farnsworth dale at farnsworth.org
Fri Oct 14 23:56:41 EST 2005


In article <1129233624.4161.30.camel at localhost.localdomain> Nicolas DET wrote:
> Added proper entry to support the Marvell MV64361 (Marvell Discovery II)
> SRAM.

Hi Nicolas,

I noticed a couple of style issues.

> +// Pegasos II location and size for the SRAM stuff

C++ style comments are discouraged in the kernel source.

> -	static struct pci_device_id pci_marvell_mv64360[] = {
> +	static struct pci_device_id pci_marvell_mv64360[] =
> +	{

> +	if (pci_dev_present(pci_marvell_mv64360))
> +	{

Open brace should not be on a line by itself except in function definitions.


-Dale Farnsworth



More information about the Linuxppc-dev mailing list