[PATCH] Fix USB suspend/resume crasher

Benjamin Herrenschmidt benh at kernel.crashing.org
Fri Nov 25 08:01:27 EST 2005

> Well, it's there (actually the problem occurs in vanilla 2.6.15-rc2-mm1 that
> contains the patch).  Do you mean it should go before the
> if (readl(&ehci->regs->configured_flag) != FLAG_CF)
> 		goto restart;
> thing?


> > It may be worth following it with a memory barrier actually... just in case
> > (due to the absence of locks in that area).
> wmb()?


I wrote that patch against a tree that had different things in that
function, Greg merged it by hand but he got that little bit wrong
unfortunately. I'll send a new patch later today.


More information about the Linuxppc-dev mailing list