[PATCH] ppc boot: replace string labels with numbers

Hollis Blanchard hollis at penguinppc.org
Sat Nov 19 02:30:03 EST 2005


On Nov 18, 2005, at 1:42 AM, Olaf Hering wrote:

>  On Thu, Nov 17, Jerry Van Baren wrote:
>
>> While I'm being dumb, I gotta ask, how big is zImage and why does 117
>> bytes make a difference?
>
> Because we can.
>
>> My 2c: if you are going to use inscrutable labels (1,2,3,4), please 
>> put
>> comments in.  At least the previous labels gave hints as to what was
>> happening.
>
> The code should be obvious.

I hope the above was a joke, Olaf.

I too am wondering where the savings come from. Regardless, IMHO 117 
bytes is not a worthwhile tradeoff for less maintainable assembly.

BTW, Jerry, the size of the instructions themselves will not change. I 
suspect the savings is from things like the symbol table, but I can't 
replicate it with a simple "hello world" testcase.

-Hollis




More information about the Linuxppc-dev mailing list