building ppc_htab?

[Tom Rini]

On Thu, Mar 17, 2005 at 10:41:37AM -0700, Tom Rini wrote:
> On Thu, Mar 17, 2005 at 11:34:14AM -0600, Kumar Gala wrote:
> > 
> > On Mar 16, 2005, at 4:11 PM, Tom Rini wrote:
> > 
> > >On Wed, Mar 16, 2005 at 12:57:24AM -0600, Kumar Gala wrote:
> > >
> > >> Is there any reason not to make the following change so we build
> > >> ppc_htab only on PPC STD MMU?? This would also require fixing up
> > >> fs/proc/proc_misc.c.
> > >
> > >I could have sworn, but maybe my memory sucks, that we no longer messed
> > >w/ fs/proc/proc_misc.c for any of the PPC-specific things (since in 2.6
> > > you can do all of that proc magic in your 'driver').? So this patch
> > > would make a great deal of sense to do, and if it lacks what I'm 
> > >talking
> > > about, we should do that part as well :)
> > 
> > I'm not exactly clear on what you are talking about.  There is this 
> > snippet in fs/proc/proc_misc.c:
> 
> Crap :(
> 
> > #ifdef CONFIG_PPC32
> >         {
> >                 extern struct file_operations ppc_htab_operations;
> >                 entry = create_proc_entry("ppc_htab", S_IRUGO|S_IWUSR, 
> > NULL);
> >                 if (entry)
> >                         entry->proc_fops = &ppc_htab_operations;
> >         }
> > #endif
> > 
> > Are you suggesting this should live elsewhere?  I'm not that familiar 
> > with proc code.
> 
> Yes, it should live in ppc_htab.c.  See the CONFIG_SYSCTL stuff already
> in ppc_htab.c for l2crvec.

Der, that's not the same thing!  I still swear there's a way to do this
w/o messing w/ fs/proc/proc_misc.c, but I don't recall a good example.

-- 
Tom Rini
http://gate.crashing.org/~trini/